Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stations_ogimet.R #91

Merged
merged 2 commits into from
May 10, 2024
Merged

Update stations_ogimet.R #91

merged 2 commits into from
May 10, 2024

Conversation

Nowosad
Copy link
Collaborator

@Nowosad Nowosad commented May 10, 2024

@bczernecki I've noticed that the station_names attribute has a space after the station name. This PR fixed this.

Current code:

library(climate)
pl = stations_ogimet(country = "Poland", add_map = FALSE)
#> [1] "http://ogimet.com/cgi-bin/gsynres?lang=en&state=Poland&osum=no&fmt=html&ord=REV&ano=2024&mes=05&day=10&hora=06&ndays=1&Send=send"
#> /tmp/RtmpHBypkH/fileb1c1e6030fd03
head(pl$station_names)
#> [1] "Petrobaltic Beta " "Kolobrzeg "        "Koszalin "        
#> [4] "Ustka "            "Leba "             "Lebork "

After changes:

library(climate)
pl = stations_ogimet(country = "Poland", add_map = FALSE)
#> [1] "http://ogimet.com/cgi-bin/gsynres?lang=en&state=Poland&osum=no&fmt=html&ord=REV&ano=2024&mes=05&day=10&hora=06&ndays=1&Send=send"
#> /tmp/RtmpBRdw9H/fileb1d0237284782
head(pl$station_names)
#> [1] "Petrobaltic Beta" "Kolobrzeg"        "Koszalin"         "Ustka"           
#> [5] "Leba"             "Lebork"

@Nowosad Nowosad requested a review from bczernecki May 10, 2024 13:11
@bczernecki
Copy link
Owner

LGTM. Merging

@bczernecki bczernecki merged commit 218092b into master May 10, 2024
6 of 8 checks passed
@bczernecki bczernecki deleted the Nowosad-patch-1 branch May 10, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants