Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bcrypto. #803

Closed
wants to merge 1 commit into from
Closed

update bcrypto. #803

wants to merge 1 commit into from

Conversation

nodech
Copy link
Member

@nodech nodech commented Jun 25, 2019

[email protected] updates

Changelog from [email protected]: bcoin-org/bcrypto#22

switching to bcrypto

Following libraries have been included in bcrypto@4: bsip, mrmr, bstring
and bs32. So this PR will use bcrypto version instead of separate packages.

Overview of repositories regarding to these libraries:

  • bsip - siphash
    • bcoin/bip152 compact block
    • Golomb PR switch from bsip to bcrypto. (already has bcrypto)
  • mrmr - Murmur3 non-crypto hash function.
    • bcoin/hostlist - used for distributing hosts into buckets.
    • bfilter PR switch from mrmr to bcrypto (downside is size)
  • bstring - bech32, base58 encodings (and cashaddr)
    • bcoin - NOTE: changed bech32.decode (now returns array)
    • bsigner
    • bterm
    • bmultisig PR
  • bs32 - base32 encoding (also part of bcrypto)
    • binet (small, same issue as bfilter)

bfilter and golomb can move to bcrypto OR
golomb can become part of bcoin primitives mentioned: #797


bcrypto breaking changes:

  • secp256k1
    • bledger PR - fromDER/toDER fix
    • bmultisig PR - signRecoverable and privateKeyGenerate fixes.
    • bcoin signmessage PR will need to rebase and fix
      sign/recover.
  • AES - is going to be removed (still there) in favor of ciphers(not resolved).
    • bcoin - masterkey and walletdb
    • bterm/bcfg

Updates from v4.0.1 to v4.1.0

  • Windows build fixes: PR
  • rename for naming consistency:
    • eddsa(including ed448, ed25519) batchVerify -> verifyBatch
    • ecdsa(including secp256k1) schnorrBatchVerify -> schnorrVerifyBatch
    • schnorr batchVerify -> verifyBatch
  • other improvements to bn, curves,

@codecov-io

This comment has been minimized.

@nodech nodech changed the title pkg: update bcrypto. Krpkg: update bcrypto. Jun 26, 2019
@nodech nodech changed the title Krpkg: update bcrypto. update bcrypto. Jun 26, 2019
@braydonf
Copy link
Contributor

So this is waiting for bfilter to be part of bcrypto? I don't think golomb is currently used and can be handled with #797

@nodech
Copy link
Member Author

nodech commented Jun 26, 2019

Actually, this can be merged without bfilter update or merge with bcrypto.

bfilter itself does not depend on bcrypto and having mrmr in bfilter for now is not a big deal.

@nodech nodech marked this pull request as ready for review June 26, 2019 19:23
@braydonf braydonf added the ready for review Ready to be reviewed label Jun 26, 2019
@braydonf
Copy link
Contributor

braydonf commented Jul 1, 2019

New version of bcrypto is tagged v4.1.0.

@tuxcanfly
Copy link
Member

Yep, should be bcrypto:4.1.0.

Would be good to get bcoin-org/mrmr#1 in and update mrmr version.

Tested and fixes npm install on windows with the above updates.

use mrmr, bstring and bsip from bcrypto
@braydonf
Copy link
Contributor

braydonf commented Jul 3, 2019

From discussion earlier, bfilter and golomb packages should either be a part of bcoin or bcrypto. And so there isn't two mrmr dependencies, bfilter can be updated to use mrmr from bcrypto. Part of this update?

@tynes
Copy link
Member

tynes commented Sep 13, 2019

@nodar-chkuaselidze can you rebase? Or I rebased here: nodech#1

@braydonf braydonf added waiting for rebase The PR needs to be updated before it can be merged and removed ready for review Ready to be reviewed labels Oct 8, 2019
@braydonf braydonf added this to the v2.0.0 milestone Jan 7, 2020
@braydonf
Copy link
Contributor

I've incorporated this into #946

@braydonf braydonf removed this from the v2.0.0 milestone Feb 18, 2020
@braydonf braydonf removed the waiting for rebase The PR needs to be updated before it can be merged label Feb 18, 2020
@braydonf braydonf closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants