-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add korean word module to hd mnemonic #1158
add korean word module to hd mnemonic #1158
Conversation
I'd like to see some tests before we get it merged. |
Tested ACK. |
8dfef57
to
9e9d1c8
Compare
alright |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1158 +/- ##
=======================================
Coverage 69.55% 69.56%
=======================================
Files 158 159 +1
Lines 26603 26607 +4
=======================================
+ Hits 18505 18509 +4
Misses 8098 8098
☔ View full report in Codecov by Sentry. |
Where is the word list from? I don't understand the language but it doesn't look like it matches https://github.com/bitcoinjs/bip39/blob/master/src/wordlists/korean.json or https://github.com/bitcoin/bips/blob/master/bip-0039/korean.txt Same question about the test vectors, where are those from? |
It's same with the former one(bitcoinjs/bip39). |
ah ok, its just the rendering that confused me, compare https://github.com/bitcoinjs/bip39/blob/master/src/wordlists/korean.json |
ok please just fix the lint error (single quotes) |
line error fixed |
Korea is one of the largest in terms of the number of users in crypto.
I refer to bip39.js where Korean support is implemented.
expect zero harm with useful utility.