Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neutrino #1155
base: master
Are you sure you want to change the base?
Neutrino #1155
Changes from all commits
f035265
23da8ac
6ab4b66
3d2951c
e9aa064
5e2bc49
3e8f061
a6a3a86
9739d20
565d155
dca0400
d6297d4
965c56c
4be3023
4832f54
fdc3f91
d374238
c73dfcf
a8281f6
a2c7aba
7b70e3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change automatic from you linter? The original code doesn't fail the bcoin lint tests, lets leave it alone since it just makes reviewing your work a bit more confusing (there's several nits like this in the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still feeling like we can get away with a chain in SPV mode but a pool in neutrino mode, which might mean we can leave chain.js mostly alone. But I'm just starting to dig in here so I defer to you