Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let version returned from getnetworkinfo be an int #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dagurval
Copy link

This closer mimics the Bitcoin Core RPC interface.

This change is needed to get bcash working with electrs.

This closer mimics the Bitcoin Core RPC interface
@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #130 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   55.55%   55.58%   +0.03%     
==========================================
  Files         109      109              
  Lines       27184    27187       +3     
  Branches     4498     4498              
==========================================
+ Hits        15102    15112      +10     
+ Misses      12082    12075       -7
Impacted Files Coverage Δ
lib/node/rpc.js 23.11% <100%> (+0.56%) ⬆️
lib/utils/binary.js 53.84% <0%> (-5.13%) ⬇️
lib/net/pool.js 16.12% <0%> (+0.1%) ⬆️
lib/btc/amount.js 16.16% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf1eeb...92b795f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants