Ds2438 fixes #35
Open
Ds2438 fixes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
requested changes
Feb 26, 2023
|
Also, I don't have any hardware that is using this, so if someone can confirm the fix that would be helpful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Brian,
I noticed that the conversion of the Vsense data seems incorrect if the returned number is negative, i.e. with the sign bit(s) set. As per the data sheet the register value is a 12+1 bit 2's complement value, so the negation of the 12 unsigned value is not the correct way to handle this situation. Please find a fix in the supplied patch.
Best regards,
Ulrich