-
Notifications
You must be signed in to change notification settings - Fork 408
switch to picocolors for console formatting #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Is there a benefit of this approach for your use case? Presumably, this would add a dependency to your project. |
It doesn't require someone to install an undocumented dependency in order to get highlighting. We could keep it as being included at runtime, but it might be nice to mention that you need to install it and this would still be a lightweight package that users are more likely to already have in their dependency tree |
Log highlighting is something you can only enable locally, in development -- I'm not sure it would make much sense in production, unless you have a use case in mind? See json-schema-to-typescript/src/utils.ts Lines 238 to 241 in 118d6a8
|
Yeah, I agree it doesn't really make sense in production. I've moved it back to dynamically requiring the library |
Any news?
|
To be clear, there's no security concern. The package prints a message instructing users how to circumvent Russian censorship regarding the war in Ukraine using Tor and a Russian anti-virus company is flagging it as a result. However, I still think this is a good change as it dramatically reduces the number of dev dependencies |
I know, and I don't care the background. 🤣 |
https://npmgraph.js.org/?q=cli-color - 14 dependencies
https://npmgraph.js.org/?q=picocolors - 0 dependencies