Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/DEVSU-2492 add minimal scope to kbmatch #411

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Dec 16, 2024

DEVSU-2492

  • add minimal scope to kbMatches
  • remove unnecessary "includes" with kbmatches to make the query fast

@sshugsc sshugsc self-assigned this Dec 16, 2024
@elewis2 elewis2 self-requested a review December 17, 2024 19:48

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.02%. Comparing base (11a532b) to head (b6de65e).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #411      +/-   ##
===========================================
+ Coverage    76.93%   77.02%   +0.09%     
===========================================
  Files          179      179              
  Lines         6057     6033      -24     
  Branches       719      695      -24     
===========================================
- Hits          4660     4647      -13     
+ Misses        1321     1310      -11     
  Partials        76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nithriel Nithriel merged commit 23a8c24 into develop Dec 19, 2024
6 checks passed
Copy link

Unit Test Results

    1 files  ±0    62 suites  ±0   2m 45s ⏱️ -1s
565 tests ±0  565 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
562 runs  ±0  562 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b6de65e. ± Comparison against base commit 11a532b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants