Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feature/DEVSU-2384-permission-storage-improvement"" #389

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Nithriel
Copy link
Contributor

@Nithriel Nithriel commented Oct 8, 2024

This reverts commit cd9869d.

@Nithriel Nithriel requested a review from elewis2 October 8, 2024 20:10
@Nithriel Nithriel self-assigned this Oct 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (a664414) to head (45f4a95).

Files with missing lines Patch % Lines
app/routes/user/member.js 66.66% 1 Missing and 1 partial ⚠️
app/middleware/group.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #389      +/-   ##
===========================================
- Coverage    76.66%   76.62%   -0.05%     
===========================================
  Files          172      171       -1     
  Lines         5855     5813      -42     
  Branches       699      702       +3     
===========================================
- Hits          4489     4454      -35     
+ Misses        1292     1283       -9     
- Partials        74       76       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

Copy link

Unit Test Results

    1 files  ±0    60 suites  ±0   2m 29s ⏱️ -10s
544 tests  - 6  544 ✔️  - 6  0 💤 ±0  0 ❌ ±0 
541 runs   - 6  541 ✔️  - 6  0 💤 ±0  0 ❌ ±0 

Results for commit 45f4a95. ± Comparison against base commit a664414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants