Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/DEVSU-834-add-email-when-user-assigned #269

Closed

Conversation

Nithriel
Copy link
Contributor

Feature:

  • Add notifications when user is bound

@Nithriel Nithriel requested a review from elewis2 August 25, 2023 22:12
@Nithriel Nithriel self-assigned this Aug 25, 2023
@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch coverage: 53.33% and project coverage change: -0.26% ⚠️

Comparison is base (62850e2) 80.26% compared to head (caf02a6) 80.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #269      +/-   ##
===========================================
- Coverage    80.26%   80.01%   -0.26%     
===========================================
  Files          156      157       +1     
  Lines         4931     4973      +42     
  Branches       536      545       +9     
===========================================
+ Hits          3958     3979      +21     
- Misses         933      948      +15     
- Partials        40       46       +6     
Files Changed Coverage Δ
app/constants.js 100.00% <ø> (ø)
app/models/notification/notification.js 55.55% <ø> (ø)
app/libs/email.js 42.85% <42.85%> (ø)
app/routes/report/reportUser.js 83.07% <83.33%> (-0.26%) ⬇️
app/config.js 76.36% <100.00%> (+0.43%) ⬆️
app/routes/notification/notification.js 73.68% <100.00%> (+0.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Unit Test Results

    1 files  ±0    55 suites  ±0   2m 21s ⏱️ -27s
424 tests ±0  424 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
420 runs  ±0  420 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit caf02a6. ± Comparison against base commit 62850e2.

@@ -20,6 +20,7 @@ if (ENV === 'production') {
}

const DEFAULT_TEST_USER = 'ipr-bamboo-admin';
const DEFAULT_EMAIL_ADDRESS = 'rpletz';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this 'dat' or 'ipr', so it targets the team.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually what happens if there's just no default email address?

@Nithriel Nithriel closed this Dec 27, 2023
@kttkjl kttkjl mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants