-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Loki Log Streaming #1385
feat: Loki Log Streaming #1385
Conversation
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
227c6a2
to
592789b
Compare
Rebased and resolved package conflicts |
@amanji there's a pull request here that refactors some startup to a |
Let's give it a try. I doubt there will be a huge impact |
Deployment URLs ready for review. |
bea4259
to
c8e0a77
Compare
Signed-off-by: Akiff Manji <[email protected]>
c8e0a77
to
48818a4
Compare
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
I'll update the PR to hide the log feature when the |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
@amanji it does not look like changes have been pushed since this - can you confirm? Would you be able to push the above tweak so we can move forward with reviewing/merging the pr? |
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Getting a fail on one of the loki fields during Helm deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor tweaks, looks good otherwise.
Getting a local docker error as well for me on fresh setuo Built fresh ( If I install the loki plugin I guess we could add the plugin install to the manage script? Want to support people starting up without needing logging setup so I'm not sure if there's a way to make that plugin more optional? |
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 - Will log follow-up tickets as needed
Thank you for taking this over @loneil |
No description provided.