Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for 201 Pipelines lab #27

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Changes for 201 Pipelines lab #27

merged 1 commit into from
Apr 20, 2022

Conversation

jayfray12
Copy link
Contributor

I have made 2 changes:

  1. Modified the Sonar project and org to be consistent with the BCGov. If the user is a member of BCGov then these values will work. Otherwise, the ci-testing values won't work out of the box
  2. I had some issues getting the triggers to work.
  • The binding, template and pipeline refs didn't match
  • The TriggerBinding params didn't match the fields in the TriggerTemplate

caggles
caggles approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@caggles caggles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gregnrobinson
Copy link
Contributor

Lgtm. The triggers and trigger bindings didn't get much love throughout the project due to other priorities.

Appreciate the ongoing changes.

@jayfray12 jayfray12 mentioned this pull request Apr 20, 2022
Closed
3 tasks
@jayfray12 jayfray12 merged commit 465b9db into main Apr 20, 2022
@jayfray12 jayfray12 deleted the ocp-201-lab branch April 20, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caggles caggles caggles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayfray12 @gregnrobinson @caggles