Merge pull request #417 from NickPhura/ACRFD-4-2

ACRFD-4-2: Update amendment text.
bcgov · Aug 15, 2019 · d477804 · d477804
2 parents c3d1577 + c46cb2a
commit d477804
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/app/services/application.service.spec.ts b/src/app/services/application.service.spec.ts
@@ -275,9 +275,9 @@ describe('ApplicationService', () => {
       expect(service.getStatusStringLong(application)).toBe('Unknown Status');
     });
 
-    it('with status ABANDONED and reason AMENDMENT APPROVED - APPLICATION it returns "Amendment: Approved"', () => {
+    it('with status ABANDONED and reason AMENDMENT APPROVED - APPLICATION it returns "Decision: Approved ..."', () => {
       application = new Application({ status: 'ABANDONED', reason: 'AMENDMENT APPROVED - APPLICATION' });
-      expect(service.getStatusStringLong(application)).toBe('Amendment: Approved');
+      expect(service.getStatusStringLong(application)).toBe('Decision: Approved - Tenure Issued');
     });
 
     it('with status ABANDONED it returns "Abandoned"', () => {

diff --git a/src/app/utils/constants/application.ts b/src/app/utils/constants/application.ts
@@ -77,7 +77,10 @@ export class StatusCodes implements ICodeSet {
 /**
  * Application Reason codes.
  *
- * Note: the reason code indicates additional information about the status code.
+ * Note:
+ *  - the reason code indicates additional information about the status code.
+ *  - the reason codes don't have unique text, instead they use the same text as their Status
+ *    counterpart: (Decision_Approved and Decision_Not_Approved).
  *
  * @export
  * @class ReasonCodes
@@ -87,14 +90,14 @@ export class ReasonCodes implements ICodeSet {
   public static readonly AMENDMENT_APPROVED: ICodeGroup = {
     code: 'AMENDMENT APPROVED - APPLICATION',
     param: 'AA',
-    text: { long: 'Amendment: Approved', short: 'Amendment: Approved' },
+    text: { long: 'Decision: Approved - Tenure Issued', short: 'Approved' },
     mappedCodes: []
   };
 
   public static readonly AMENDMENT_NOT_APPROVED: ICodeGroup = {
     code: 'AMENDMENT NOT APPROVED - APPLICATION',
     param: 'ANA',
-    text: { long: 'Amendment: Not Approved', short: 'Amendment: Not Approved' },
+    text: { long: 'Decision: Not Approved', short: 'Not Approved' },
     mappedCodes: []
   };