Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CE-1066 update rationale to text field #652

Merged
merged 9 commits into from
Sep 26, 2024
Merged

feat: CE-1066 update rationale to text field #652

merged 9 commits into from
Sep 26, 2024

Conversation

Scarlett-Truong
Copy link
Contributor

@Scarlett-Truong Scarlett-Truong commented Sep 20, 2024 •
edited by github-actions bot
Loading

Description

Change Rationale field type in CEEB decision from dropdown list to text field.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@Scarlett-Truong Scarlett-Truong added the case_management_3 https://dc0a4a-compenf-dev-3-backend.apps.emerald.devops.gov.bc.ca/graphql label Sep 20, 2024
@Scarlett-Truong Scarlett-Truong changed the base branch from main to release/orca September 25, 2024 21:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Scarlett-Truong Scarlett-Truong added case_management_2 https://dc0a4a-compenf-dev-2-backend.apps.emerald.devops.gov.bc.ca/graphql and removed case_management_3 https://dc0a4a-compenf-dev-3-backend.apps.emerald.devops.gov.bc.ca/graphql labels Sep 26, 2024
@Scarlett-Truong
Copy link
Contributor Author

@barrfalk I ran the failed cypress test locally and it's successful, the timeout issue again.
Screenshot 2024-09-26 at 12 24 20 PM

@afwilcox afwilcox merged commit ccc837d into release/orca Sep 26, 2024
14 of 15 checks passed
@afwilcox afwilcox deleted the feat/CE-1066 branch September 26, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrfalk barrfalk barrfalk approved these changes

Assignees
No one assigned
Labels
case_management_2 https://dc0a4a-compenf-dev-2-backend.apps.emerald.devops.gov.bc.ca/graphql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Scarlett-Truong @barrfalk @afwilcox @marqueone-ps