Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CE-936 Add privacy indication field to complaint #647

Merged
merged 47 commits into from
Sep 24, 2024
Merged

feat: CE-936 Add privacy indication field to complaint #647

merged 47 commits into from
Sep 24, 2024

Conversation

marqueone-ps
Copy link
Contributor

@marqueone-ps marqueone-ps commented Sep 17, 2024 •
edited by github-actions bot
Loading

Description

Adds a new checkbox field to the create and edit complaint forms. This new value also needs to be made available in the exported complaint.

Story # CE-936

Acceptance Criteria

  • update model:
    • drop privacy_request_ind
    • add privacy_request
  • update interfaces to add new privacy property
  • update redux to use new privacy property
  • Add privacy request dropdown to create complaint
  • Add privacy request dropdown to edit complaint
  • make new privacy filed available for only ceeb
  • update export complaint template to use new field

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

dmitri-korin-bcps and others added 30 commits August 26, 2024 07:56
@dmitri-korin-bcps @barrfalk
@gregorylavery @Scarlett-Truong @marqueone-ps
feat: CE-202-Complaint-Type-doesnt-automatically-reclassify-as-an-Enf…
f9f3cd0 
…orcement-Complaint (#596)

Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: gregorylavery <[email protected]>
Co-authored-by: Scarlett <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: Mike Sears <[email protected]>
@marqueone-ps @barrfalk
@gregorylavery @Scarlett-Truong @dmitri-korin-bcps
fix: CE-1008 - WebEOC complaints with very long Suspect and Witness D…
b05a0ca 
…etails do not appear in NatCom (#598)

Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: gregorylavery <[email protected]>
Co-authored-by: Scarlett <[email protected]>
Co-authored-by: dmitri-korin-bcps <[email protected]>
Co-authored-by: Mike Sears <[email protected]>
@gregorylavery @barrfalk
@Scarlett-Truong @marqueone-ps @dmitri-korin-bcps
feat: CE 981 hide zone and tabs for CEEB users (#597)
96b8c51 
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: Scarlett <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: dmitri-korin-bcps <[email protected]>
Co-authored-by: Mike Sears <[email protected]>
@gregorylavery @barrfalk
fix: CE-1023 Few layout fixes to actions taken. (#603)
e3dd991 
Co-authored-by: Barrett Falk <[email protected]>
@Scarlett-Truong @gregorylavery @barrfalk
feat: CE-1004 outcome attachments for CEEB (#606)
b2cf910 
Co-authored-by: Mike Sears <[email protected]>
Co-authored-by: gregorylavery <[email protected]>
Co-authored-by: barrfalk <[email protected]>
@marqueone-ps @barrfalk
feat: CE-1013 - Update to Logic that Displays Agency Icon (#600)
e2a12f0 
Co-authored-by: Mike Sears <[email protected]>
Co-authored-by: Barrett Falk <[email protected]>
@barrfalk
fix: CE-1004 add plus icon to button (#608)
bd20923
@barrfalk
fix: CE-1004-fix-attachment-text-casing (#609)
1cac931
@Scarlett-Truong @barrfalk
@gregorylavery @marqueone-ps @dmitri-korin-bcps
feat: CE-976 Admin screen for CEEB (#605)
b072e01 
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: gregorylavery <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: dmitri-korin-bcps <[email protected]>
Co-authored-by: Mike Sears <[email protected]>
@jeznorth
feat: CE-1029 - UI Updates to Complaints Tables (#614)
8a4bd67
@renovate @afwilcox
chore(deps): update jest monorepo (#611)
aff15a7 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <[email protected]>
@afwilcox
fix: CE-1036-revert-hwcr-tab-rename (#617)
9c17f3f
@gregorylavery @afwilcox
fix: Makes the naming in the list consistent. (#618)
18f3ebc 
Co-authored-by: afwilcox <[email protected]>
@marqueone-ps @barrfalk @afwilcox
feat: CE-977 create ceeb decison (#607)
d011ecb 
Co-authored-by: Mike Sears <[email protected]>
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: afwilcox <[email protected]>
@afwilcox
fix: CE-1049 Remove GIR Officer Initials (#622)
ba0cfb9
@jeznorth @afwilcox
feat: CE-776 - Keyboard Navigation Improvements - Complaints List Page (
beb8193 
#613)

Co-authored-by: afwilcox <[email protected]>
@Scarlett-Truong @afwilcox
feat: CE-1003 Add notes to CEEB complaint outcome (#621)
927ccb6 
Co-authored-by: afwilcox <[email protected]>
@renovate @afwilcox
chore(deps): update postgis/postgis:15-master docker digest to 9e03ed5 (
2c562aa 
#623)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <[email protected]>
@jeznorth @afwilcox
feat: CE-1028 - Add Close Button to Desktop Filters (#615)
ccbb38c 
Co-authored-by: afwilcox <[email protected]>
@gregorylavery @afwilcox
fix: CE 1052 Reapply the button styling for Species (#624)
d891013 
Co-authored-by: afwilcox <[email protected]>
@gregorylavery @afwilcox
fix: CE 1017 (#619)
cb1e766 
Co-authored-by: afwilcox <[email protected]>
@gregorylavery
fix: Modifies how the contstraint is added to the feature_agency_xref (…
b28a168 
…#627)
@afwilcox
fix: CE-1055 Remove Margins from decision HR (#625)
49d8048
@barrfalk
feat: CE-996-Add Method complaint was received field to Complaint (#626)
a937a6d
@marqueone-ps
feat: CE-1002 Allow CEEB users to capture authorization number (#620)
4a59540 
Co-authored-by: Mike Sears <[email protected]>
@dmitri-korin-bcps @Scarlett-Truong
@barrfalk @afwilcox
feat: CE-946-Allow-assignment-of-ceeb-complaints-to-ceeb-officers (#610)
c3eedad 
Co-authored-by: Scarlett <[email protected]>
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: Scarlett <[email protected]>
Co-authored-by: afwilcox <[email protected]>
@afwilcox
fix: CE-1073 and CE-1074 Proper Focus and Validation for Input Groups…
4abcce5 
… with bonus typo fixes (#628)
@afwilcox
fix: CE-1073: Delay UA transition out effect (#631)
a6fbb03
@Scarlett-Truong
fix: CE-1056 default filters not showing (#643)
cab1982
@marqueone-ps @afwilcox
fix: CE-1059 Unable to save Decision section without entering all fie…
6d6be66 
…lds - incorrect toast (#629)

Co-authored-by: Mike Sears <[email protected]>
Co-authored-by: afwilcox <[email protected]>
@marqueone-ps marqueone-ps changed the base branch from main to release/lewis-moon-snail September 17, 2024 21:57
complaint updates
428cc30 
added new privacy field to create and edit complaint components, updated complaint service to handle new privacy property, and updated models and mapping
@barrfalk barrfalk changed the base branch from release/lewis-moon-snail to release/orca September 19, 2024 19:26
@marqueone-ps marqueone-ps marked this pull request as ready for review September 23, 2024 17:36
afwilcox
afwilcox requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional issues but please see comments on specific code items.

backend/src/v1/complaint/complaint.service.ts Outdated Show resolved Hide resolved
frontend/src/app/components/containers/complaints/details/caller-information.tsx Outdated Show resolved Hide resolved
migrations/migrations/R__0.28.0_insert-privacy-feature.sql Outdated Show resolved Hide resolved
migrations/migrations/V0.28.0__CE-936.sql Outdated Show resolved Hide resolved
afwilcox
afwilcox requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good but there is something not working on the display (and maybe the export I didn't test that)

@marqueone-ps
Copy link
Contributor Author

Changes all look good but there is something not working on the display (and maybe the export I didn't test that)

export is working, but the thing that was off was the when I changed the name of the property vscode didn't change it everywhere, so it wasn't showing up in the ux. I've updated the interfaces to force this change back to working again.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
90.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@afwilcox afwilcox merged commit c05bd2d into release/orca Sep 24, 2024
14 of 15 checks passed
@afwilcox afwilcox deleted the feat/CE-936 branch September 24, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afwilcox afwilcox afwilcox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marqueone-ps @afwilcox @dmitri-korin-bcps @gregorylavery @Scarlett-Truong @barrfalk @jeznorth