Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NERT-320 Auth/Non-Auth project view objectives are now dynamic #92

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

oscar-ip
Copy link
Collaborator

@oscar-ip oscar-ip commented Jun 5, 2024

Links to Jira Tickets

  • NERT-320

Description of Changes

  • Auth project view now displays objectives from backend
  • Synched Non-Auth project view with Auth prj view

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.75%. Comparing base (9802928) to head (c831d38).

Files Patch % Lines
...res/projects/view/components/ProjectObjectives.tsx 30.00% 7 Missing ⚠️
app/src/pages/public/PublicProjectView.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #92      +/-   ##
==========================================
- Coverage   56.83%   56.75%   -0.09%     
==========================================
  Files         178      179       +1     
  Lines        5391     5404      +13     
  Branches      967      971       +4     
==========================================
+ Hits         3064     3067       +3     
- Misses       2143     2153      +10     
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscar-ip oscar-ip requested review from KjartanE and popkinj June 5, 2024 20:13
Copy link
Collaborator

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oscar-ip oscar-ip merged commit ab6e36b into dev Jun 5, 2024
14 of 16 checks passed
@oscar-ip oscar-ip deleted the NERT-320c branch June 5, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants