Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NERT-320 api and data model work to support project objectives, other changes #90

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

oscar-ip
Copy link
Collaborator

@oscar-ip oscar-ip commented Jun 5, 2024

Links to Jira Tickets

  • NERT-320

Description of Changes

  • project objective are now supported by the API and data model
  • other minor changes in partnership

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 56.83%. Comparing base (44025e5) to head (fbd8979).

Files Patch % Lines
api/src/services/project-service.ts 20.00% 22 Missing and 2 partials ⚠️
api/src/models/project-create.ts 50.00% 1 Missing and 2 partials ⚠️
...ures/projects/components/ProjectObjectivesForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #90      +/-   ##
==========================================
- Coverage   56.97%   56.83%   -0.15%     
==========================================
  Files         178      178              
  Lines        5346     5391      +45     
  Branches      955      967      +12     
==========================================
+ Hits         3046     3064      +18     
- Misses       2120     2143      +23     
- Partials      180      184       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscar-ip oscar-ip requested review from KjartanE and popkinj June 5, 2024 02:13
Copy link
Collaborator

@popkinj popkinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would like to get this into dev asap.

@oscar-ip oscar-ip merged commit 9802928 into dev Jun 5, 2024
13 of 15 checks passed
@oscar-ip oscar-ip deleted the NERT-320b branch June 5, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants