Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoration Plan: Create/View/Edit #83

Merged
merged 13 commits into from
May 31, 2024
Merged

Restoration Plan: Create/View/Edit #83

merged 13 commits into from
May 31, 2024

Conversation

KjartanE
Copy link
Collaborator

@KjartanE KjartanE marked this pull request as ready for review May 29, 2024 22:27
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 2.59366% with 676 lines in your changes are missing coverage. Please review.

Project coverage is 57.25%. Comparing base (b59b3c6) to head (3dbc149).

Files Patch % Lines
api/src/repositories/project-repository.ts 5.22% 127 Missing ⚠️
app/src/features/plans/create/CreatePlanPage.tsx 0.00% 93 Missing ⚠️
app/src/features/plans/view/ViewPlanPage.tsx 0.00% 68 Missing ⚠️
app/src/features/plans/edit/EditProjectPage.tsx 0.00% 49 Missing ⚠️
...src/features/plans/components/PlanLocationForm.tsx 0.00% 48 Missing ⚠️
.../src/features/plans/components/PlanContactForm.tsx 0.00% 27 Missing ⚠️
api/src/repositories/plan-repository.ts 0.00% 24 Missing ⚠️
api/src/services/plan-service.ts 0.00% 24 Missing ⚠️
app/src/hooks/api/usePlanApi.ts 4.00% 24 Missing ⚠️
api/src/paths/plan/list.ts 0.00% 22 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #83      +/-   ##
==========================================
- Coverage   66.65%   57.25%   -9.40%     
==========================================
  Files         149      176      +27     
  Lines        4498     5341     +843     
  Branches      833      962     +129     
==========================================
+ Hits         2998     3058      +60     
- Misses       1332     2102     +770     
- Partials      168      181      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KjartanE KjartanE requested a review from oscar-ip May 29, 2024 23:02
Copy link
Collaborator

@oscar-ip oscar-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@KjartanE KjartanE merged commit e442f0d into dev May 31, 2024
13 of 15 checks passed
@KjartanE KjartanE deleted the NERT-341 branch May 31, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants