Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup states the correct Masking value #269

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

Popup states the correct Masking value #269

wants to merge 7 commits into from

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Oct 18, 2024

  • Any map geometry within a multiple geometry containing a mask sets the Mask flag for the entire multiple geometry.
  • Masks are once again being sent to public users on the search page instead of the original geometries.
  • Fixed infinite loop. It was a react hook not a nested foreach clause

Screenshot from 2024-10-18 12-31-20

@popkinj popkinj marked this pull request as ready for review October 18, 2024 20:12
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.90%. Comparing base (2b59210) to head (c7ee12e).

Files with missing lines Patch % Lines
api/src/paths/search.ts 77.77% 2 Missing ⚠️
app/src/components/map/MapContainer.tsx 0.00% 2 Missing ⚠️
app/src/features/search/SearchPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #269      +/-   ##
==========================================
+ Coverage   41.85%   41.90%   +0.05%     
==========================================
  Files         321      321              
  Lines       10280    10284       +4     
  Branches     1922     1920       -2     
==========================================
+ Hits         4303     4310       +7     
+ Misses       5768     5765       -3     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popkinj popkinj requested review from KjartanE and oscar-ip October 18, 2024 21:33
@KjartanE KjartanE added the bug Something isn't working label Oct 18, 2024
@KjartanE KjartanE marked this pull request as draft October 18, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants