Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NERT-184 fixed keyboard navigation issue #265

Merged
merged 1 commit into from
Oct 16, 2024
Merged

NERT-184 fixed keyboard navigation issue #265

merged 1 commit into from
Oct 16, 2024

Conversation

oscar-ip
Copy link
Collaborator

Links to Jira Tickets

  • NERT-184

Description of Changes

  • Breadcrumbs components now focusable allowing keyboard navigation

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.44%. Comparing base (933756b) to head (ff86154).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ures/plans/participants/PlanParticipantsHeader.tsx 0.00% 1 Missing ⚠️
...rojects/participants/ProjectParticipantsHeader.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #265   +/-   ##
=======================================
  Coverage   39.44%   39.44%           
=======================================
  Files         320      320           
  Lines       10186    10186           
  Branches     1892     1892           
=======================================
  Hits         4018     4018           
  Misses       5963     5963           
  Partials      205      205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscar-ip oscar-ip requested review from KjartanE and popkinj October 16, 2024 17:10
Copy link
Collaborator

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱 Looks good

@oscar-ip oscar-ip merged commit e595318 into dev Oct 16, 2024
19 of 21 checks passed
@oscar-ip oscar-ip deleted the NERT-184 branch October 16, 2024 19:42
KjartanE pushed a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants