Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NERT-712 Issue with PI report resolved and also with Date ranges sele… #262

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

oscar-ip
Copy link
Collaborator

…ction

Links to Jira Tickets

  • NERT-712

Description of Changes

  • Fixed issue with PI report when projects or plans are deleted
  • Fixed issue with date range selections in API and APP

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39.44%. Comparing base (20c5733) to head (01c4ffb).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
api/src/repositories/report-repository.ts 0.00% 10 Missing ⚠️
app/src/features/admin/reports/ReportsPage.tsx 0.00% 7 Missing ⚠️
...src/features/admin/reports/AppCustomReportPage.tsx 0.00% 3 Missing ⚠️
...src/features/admin/reports/AppPiMgmtReportPage.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #262      +/-   ##
==========================================
- Coverage   39.54%   39.44%   -0.10%     
==========================================
  Files         320      320              
  Lines       10176    10186      +10     
  Branches     1891     1892       +1     
==========================================
- Hits         4024     4018       -6     
- Misses       5947     5963      +16     
  Partials      205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscar-ip oscar-ip requested review from popkinj and KjartanE October 11, 2024 23:48
Copy link
Collaborator

@popkinj popkinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@oscar-ip oscar-ip merged commit 933756b into dev Oct 15, 2024
18 of 21 checks passed
@oscar-ip oscar-ip deleted the NERT-712 branch October 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants