Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nert 693 - Print button is active #259

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Nert 693 - Print button is active #259

merged 4 commits into from
Oct 10, 2024

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Oct 9, 2024

  • Connecting the print buttons
  • Turning off canvas setting that was causing the map to freeze in some situations.
  • Fixed the MUI4 errors

@popkinj popkinj requested review from KjartanE and oscar-ip October 9, 2024 21:57
@oscar-ip
Copy link
Collaborator

oscar-ip commented Oct 9, 2024

open a draft the map is still freezes when testing in the PR

@popkinj
Copy link
Collaborator Author

popkinj commented Oct 9, 2024

open a draft the map is still freezes when testing in the PR

Ok... thanks for testing.
For some reason I'm not seeing that anymore. Hmmmm... 🤔
Let me figure out how to reproduce that behaviour so I can get it sorted out.

Copy link
Collaborator

@oscar-ip oscar-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the PR and still see the map freezing when creating a draft
I am Approving this PR and I will create a new jira item to deal with that freeze scenario

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (80c1e89) to head (9f2c848).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
app/src/features/plans/view/ViewPlanPage.tsx 0.00% 2 Missing ⚠️
app/src/features/projects/view/ViewProjectPage.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #259      +/-   ##
==========================================
- Coverage   39.52%   39.50%   -0.02%     
==========================================
  Files         320      320              
  Lines       10166    10170       +4     
  Branches     1890     1890              
==========================================
  Hits         4018     4018              
- Misses       5943     5947       +4     
  Partials      205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popkinj popkinj merged commit 20c5733 into dev Oct 10, 2024
18 of 21 checks passed
@popkinj popkinj deleted the NERT-693 branch October 10, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants