Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nert 689 - Downloading masks from all list exports #251

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Nert 689 - Downloading masks from all list exports #251

merged 11 commits into from
Oct 4, 2024

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Oct 3, 2024

  • Public and Non-Public list pages (projects and plans) now send the mask instead of the original geometry (when specified).
  • The project/plan centroids now disclaim the level of accuracy.
    Screenshot from 2024-10-02 11-14-44

@popkinj popkinj requested review from KjartanE and oscar-ip October 3, 2024 17:57
@popkinj
Copy link
Collaborator Author

popkinj commented Oct 3, 2024

I'm guessing this is failing due to the same issue we had before.... empty geometries??

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.

Project coverage is 40.05%. Comparing base (a26ba99) to head (3d266ce).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
api/src/paths/plan/list.ts 33.33% 3 Missing and 1 partial ⚠️
api/src/paths/project/list.ts 33.33% 3 Missing and 1 partial ⚠️
api/src/paths/public/plans.ts 33.33% 3 Missing and 1 partial ⚠️
api/src/paths/public/projects.ts 33.33% 3 Missing and 1 partial ⚠️
app/src/components/map/components/Popup.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #251      +/-   ##
==========================================
- Coverage   40.08%   40.05%   -0.04%     
==========================================
  Files         315      315              
  Lines        9963     9988      +25     
  Branches     1859     1865       +6     
==========================================
+ Hits         3994     4001       +7     
- Misses       5768     5782      +14     
- Partials      201      205       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popkinj popkinj requested a review from KjartanE October 4, 2024 20:48
Copy link
Collaborator

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@popkinj popkinj merged commit 1f1a188 into dev Oct 4, 2024
17 of 20 checks passed
@popkinj popkinj deleted the NERT-689 branch October 4, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants