Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NERT-652b PI report completed #250

Merged
merged 1 commit into from
Oct 3, 2024
Merged

NERT-652b PI report completed #250

merged 1 commit into from
Oct 3, 2024

Conversation

oscar-ip
Copy link
Collaborator

@oscar-ip oscar-ip commented Oct 2, 2024

Links to Jira Tickets

  • NERT-652, NERT-654, NERT-655

Description of Changes

  • API for PI report completed
  • PI report page now completed.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 2.27273% with 43 lines in your changes missing coverage. Please review.

Project coverage is 40.08%. Comparing base (fc90a4b) to head (75f2b9a).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
api/src/paths/reports/pi/view.ts 0.00% 16 Missing ⚠️
...src/features/admin/reports/AppPiMgmtReportPage.tsx 0.00% 16 Missing ⚠️
api/src/repositories/report-repository.ts 0.00% 7 Missing ⚠️
api/src/services/reports-service.ts 0.00% 2 Missing ⚠️
app/src/hooks/api/useAdminApi.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #250      +/-   ##
==========================================
- Coverage   40.23%   40.08%   -0.16%     
==========================================
  Files         314      315       +1     
  Lines        9923     9963      +40     
  Branches     1852     1859       +7     
==========================================
+ Hits         3993     3994       +1     
- Misses       5729     5768      +39     
  Partials      201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscar-ip oscar-ip requested review from popkinj and KjartanE October 2, 2024 23:24
Copy link
Collaborator

@popkinj popkinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. :)

@oscar-ip oscar-ip merged commit 8e132bd into dev Oct 3, 2024
19 of 21 checks passed
@oscar-ip oscar-ip deleted the NERT-652b branch October 3, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants