feature/deseng745: Updated project definition to add project type multi-select values. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jareth-whitney
commented
Nov 22, 2024
jareth-whitney
commented
- Updated project definition to add project type multi-select values.
Baelx
requested changes
Nov 25, 2024
api/swagger/swagger.yaml
Outdated
| @@ -2629,6 +2651,14 @@ paths: | |||
| description: "The project phase of the file." | |||
| required: false | |||
| type: string | |||
| - name: projectTypes | |||
There was a problem hiding this comment.
Why do Documents need a project type? Isn't this field just meant for projects only?
Just from reading the ticket, it looks like you'd need the projectTypes field in 4 places:
- authenticated (/project) get
- auth'd put
- auth'd post
- public (/public/project) get
There was a problem hiding this comment.
Thanks for catching it, just a misplaced field.
| @@ -32,7 +32,8 @@ | |||
| proMember : '{{lorem(1, "words")}}', | |||
| provElecDist : '{{lorem(1, "words")}}', | |||
| shortName : '{{lorem(1, "words")}}', | |||
| projectPhase : '{{lorem(1, "words")}}', | |||
| projectPhase : '{{lorem(1, "words")}}', | |||
There was a problem hiding this comment.
Thanks for the due diligence but we don't need to update this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.