Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/docker-image-version-and-py-dependencies #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bartekus
Copy link

  • Add & update deps, adjust integration test to handle python 3.7 to 3.6 downgrade

Signed-off-by: bartekus [email protected]

@bartekus
Copy link
Author

Just wanted to escalate the version update as we are currently experiencing issues with revocation ranging from random PUT failures to not accepting revocation entries which have empty spaces in them (a schema with human readable name for example)

@swcurran swcurran requested a review from WadeBarnes June 28, 2022 23:22
@swcurran
Copy link
Contributor

@WadeBarnes -- please review. Thanks!

Thanks, @bartekus !

@bartekus
Copy link
Author

@bartekus bartekus force-pushed the upkeep/docker-image-version-and-py-dependencies branch from d88b105 to c7fc10b Compare June 29, 2022 01:31
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to downgrade to Python 3.6 since it's EOL and no longer supported. The better option would be to update the base image to the next-2 image or even update the base image code and create a new release of the base image(s); https://github.com/bcgov/von-image

@bartekus
Copy link
Author

Is there anything I can do regarding the new base image being created then updating this to that revision?

@WadeBarnes
Copy link
Member

@bartekus, If you have time you could see if the next-2 image works for the purpose, and/or look into updating the next set of images to suit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants