Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve template file handling #113

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Improve template file handling #113

merged 1 commit into from
Jul 25, 2024

Conversation

TimCsaky
Copy link
Contributor

Description

when a high frequency of requests hit the app,
template files are not managed consistently.
fileCache.find should handle when more than one template is found.

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

when a high frequency of requests hit the app,
template files are not managed consistently.
fileCache.find should handle when more than one template is found.
Copy link

Coverage Report

Totals Coverage
Statements: 16% ( 140 / 875 )
Methods: 25.71% ( 18 / 70 )
Lines: 15.27% ( 82 / 537 )
Branches: 14.93% ( 40 / 268 )

@TimCsaky TimCsaky merged commit b9ae3d5 into master Jul 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant