Feat/345 load activity data from database #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shon-button
force-pushed
the
feat/345-load-activity-data-from-database
branch
from
33470c9
to
6b3b0b9
Compare
pbastia
force-pushed
the
feat/345-load-activity-data-from-database
branch
3 times, most recently
from
ddf1497
to
ea8e9f6
Compare
pbastia
force-pushed
the
feat/345-load-activity-data-from-database
branch
from
ea8e9f6
to
c508d59
Compare
pbastia
commented
Nov 6, 2024
| import { withTheme } from "@rjsf/core"; | ||
| import formTheme from "@bciers/components/form/theme/defaultTheme"; | ||
|
|
||
| const Form = withTheme(formTheme); |
There was a problem hiding this comment.
FormBase was introducing some unintended behaviours by also holding a copy of the formData in the state, so this uses the RJSF component directly
pbastia
force-pushed
the
feat/345-load-activity-data-from-database
branch
from
622aa16
to
773ed47
Compare
dleard
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Looks great! Love how those serializers work. Just one note on a potential performance optimization.
I've made a bug card for the issue this PR unearthed around the persistence of formState that should be handled shortly after this goes in
| def load(cls, report_version_id: int, facility_id: UUID, activity_id: int) -> dict: | ||
|
|
||
| try: | ||
| r = ReportActivity.objects.get( |
There was a problem hiding this comment.
Could this query benefit from prefetch_related?
pbastia
force-pushed
the
feat/345-load-activity-data-from-database
branch
from
2351deb
to
1676986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReportActivity,ReportUnit,ReportFuel,ReportEmissionandReportMethodologyin a format that the activity form can display and understandActivityFormto update the form data with the saved IDs and computed data