2210 run all e2e on merge to develop #2219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellmueller
force-pushed
the
2210-run-all-e2e-on-merge-to-develop
branch
3 times, most recently
from
869421d
to
3ded1f0
Compare
marcellmueller
force-pushed
the
2210-run-all-e2e-on-merge-to-develop
branch
13 times, most recently
from
f1dc13a
to
af3ec0b
Compare
marcellmueller
force-pushed
the
2210-run-all-e2e-on-merge-to-develop
branch
from
af3ec0b
to
432ba49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2210
Brianna pointed out that the
happo-skiphelper is failing on merge to main. I believe this is due to us passing in the last commit sha which works for pull requests, but doesn't seem to work here. Rather than debug this I think it's both easier and more safe to just run all e2e on merge so I moved up this issue.Initially I used
github.event.pull_request.merged == 'true'though I wanted to ensure this would run both ondevelopandmainto ensure everything is good before deployment to dev/test.