-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2136 Reg\Register an Operation\Page "Operation Representative" #2204
2136 Reg\Register an Operation\Page "Operation Representative" #2204
Conversation
13fbf9f
to
ab300e5
Compare
c6d93b8
to
152bf9b
Compare
abae100
to
1984fe3
Compare
8ed2136
to
c1a2ea6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FINALLY finished reading through the code! will pull the branch to run locally and try to break it (😈) after lunch
"/operations/{uuid:operation_id}/contacts", | ||
response={200: List[OperationsContactListOut], custom_codes_4xx: Message}, | ||
tags=OPERATION_TAGS, | ||
description="""Retrieves the list of contacts associated with the operation.""", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: flagging this wording as potentially confusing - contacts are associated with an operator, operation representatives are associated with an operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the code locally and confirmed:
- with an existing unregistered operation, I was able to select an existing contact and assign them as operation rep. The operation then showed up in the "Places Assigned" list for the contact
- with the same existing operation, I was able to create a new contact and also assign them as operation rep. The new contact then appeared in the Contacts grid, and had the appropriate "Places Assigned"
I noticed that the list of operation reps doesn't appear in the Operation Details page, so at the moment there's no way to edit the list of operation reps once the operation has been registered. However, I think that's beyond the scope of this ticket so I'm approving.
Great work!
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
This reverts commit fbd9fab.
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
8e6e4c7
to
a0de56a
Compare
Signed-off-by: SeSo <[email protected]>
Thank you @andrea-williams ! |
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
ISSUE 2136
NOTES:
TO TEST:
bc-cas-dev
and follow the AC in the Card: # 2136