Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-457: Taxonomy Endpoints #235

Merged
merged 23 commits into from
Feb 2, 2024
Merged

SIMSBIOHUB-457: Taxonomy Endpoints #235

merged 23 commits into from
Feb 2, 2024

Conversation

KjartanE
Copy link
Contributor

Links to Jira Tickets

Description of Changes

  • Added endpoint for ITIS Solr TSN search

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4df6210) 62.82% compared to head (9788d57) 63.48%.

Files Patch % Lines
api/src/repositories/taxonomy-repository.ts 88.23% 1 Missing and 1 partial ⚠️
api/src/services/itis-service.ts 95.00% 1 Missing and 1 partial ⚠️
api/src/services/taxonomy-service.ts 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #235      +/-   ##
==========================================
+ Coverage   62.82%   63.48%   +0.66%     
==========================================
  Files         265      267       +2     
  Lines        7402     7463      +61     
  Branches     1039     1039              
==========================================
+ Hits         4650     4738      +88     
+ Misses       2496     2470      -26     
+ Partials      256      255       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NickPhura
NickPhura previously approved these changes Feb 1, 2024
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

NickPhura
NickPhura previously approved these changes Feb 2, 2024
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

7.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚕

@KjartanE KjartanE merged commit e761319 into dev Feb 2, 2024
20 of 21 checks passed
@KjartanE KjartanE deleted the SIMSBIOHUB-457 branch February 2, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants