Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Financial Instrument Data Type Enums and Add Default to Status Column #2199

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Rename Financial Instrument Data Type Enums and Add Default to Status Column #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f47b58f
Rename financial instrument enums
Abradat Mar 6, 2025
94729bc
Add default to financial instrument's status column
Abradat Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...dition-financial-instrument/application-decision-condition-financial-instrument.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class ApplicationDecisionConditionFinancialInstrument extends Base {
securityHolderPayee: string;

@AutoMap()
@Column({ type: 'enum', enum: InstrumentType, nullable: false })
@Column({ type: 'enum', enum: InstrumentType, nullable: false, enumName: 'application_instrument_type' })
type: InstrumentType;

@AutoMap()
Expand All @@ -63,7 +63,7 @@ export class ApplicationDecisionConditionFinancialInstrument extends Base {
instrumentNumber: string | null;

@AutoMap()
@Column({ type: 'enum', enum: HeldBy, nullable: false })
@Column({ type: 'enum', enum: HeldBy, nullable: false, enumName: 'application_instrument_held_by' })
heldBy: HeldBy;

@AutoMap()
Expand All @@ -75,7 +75,13 @@ export class ApplicationDecisionConditionFinancialInstrument extends Base {
notes: string | null;

@AutoMap()
@Column({ type: 'enum', enum: InstrumentStatus, default: InstrumentStatus.RECEIVED, nullable: false })
@Column({
type: 'enum',
enum: InstrumentStatus,
default: InstrumentStatus.RECEIVED,
nullable: false,
enumName: 'application_instrument_status',
})
status: InstrumentStatus;

@AutoMap()
Expand Down
12 changes: 9 additions & 3 deletions ...n-financial-instrument/notice-of-intent-decision-condition-financial-instrument.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class NoticeOfIntentDecisionConditionFinancialInstrument extends Base {
securityHolderPayee: string;

@AutoMap()
@Column({ type: 'enum', enum: InstrumentType, nullable: false })
@Column({ type: 'enum', enum: InstrumentType, nullable: false, enumName: 'noi_instrument_type' })
type: InstrumentType;

@AutoMap()
Expand All @@ -63,7 +63,7 @@ export class NoticeOfIntentDecisionConditionFinancialInstrument extends Base {
instrumentNumber: string | null;

@AutoMap()
@Column({ type: 'enum', enum: HeldBy, nullable: false })
@Column({ type: 'enum', enum: HeldBy, nullable: false, enumName: 'noi_instrument_held_by' })
heldBy: HeldBy;

@AutoMap()
Expand All @@ -75,7 +75,13 @@ export class NoticeOfIntentDecisionConditionFinancialInstrument extends Base {
notes: string | null;

@AutoMap()
@Column({ type: 'enum', enum: InstrumentStatus, default: InstrumentStatus.RECEIVED, nullable: false })
@Column({
type: 'enum',
enum: InstrumentStatus,
default: InstrumentStatus.RECEIVED,
nullable: false,
enumName: 'noi_instrument_status',
})
status: InstrumentStatus;

@AutoMap()
Expand Down
53 changes: 53 additions & 0 deletions .../alcs/src/providers/typeorm/migrations/1741287102799-rename_financial_instrument_enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
import { MigrationInterface, QueryRunner } from 'typeorm';

export class RenameFinancialInstrumentEnums1741287102799 implements MigrationInterface {
name = 'RenameFinancialInstrumentEnums1741287102799';

public async up(queryRunner: QueryRunner): Promise<void> {
// Application instrument types - direct rename
await queryRunner.query(
`ALTER TYPE "alcs"."application_decision_condition_financial_instrument_type_enum" RENAME TO "application_instrument_type"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."application_decision_condition_financial_instrument_held_by_enu" RENAME TO "application_instrument_held_by"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."application_decision_condition_financial_instrument_status_enum" RENAME TO "application_instrument_status"`,
);

// Notice of intent instrument types - direct rename
await queryRunner.query(
`ALTER TYPE "alcs"."notice_of_intent_decision_condition_financial_instrument_type_e" RENAME TO "noi_instrument_type"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."notice_of_intent_decision_condition_financial_instrument_held_b" RENAME TO "noi_instrument_held_by"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."notice_of_intent_decision_condition_financial_instrument_status" RENAME TO "noi_instrument_status"`,
);
}

public async down(queryRunner: QueryRunner): Promise<void> {
// Revert notice of intent instrument types - direct rename
await queryRunner.query(
`ALTER TYPE "alcs"."noi_instrument_status" RENAME TO "notice_of_intent_decision_condition_financial_instrument_status"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."noi_instrument_held_by" RENAME TO "notice_of_intent_decision_condition_financial_instrument_held_b"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."noi_instrument_type" RENAME TO "notice_of_intent_decision_condition_financial_instrument_type_e"`,
);

// Revert application instrument types - direct rename
await queryRunner.query(
`ALTER TYPE "alcs"."application_instrument_status" RENAME TO "application_decision_condition_financial_instrument_status_enum"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."application_instrument_held_by" RENAME TO "application_decision_condition_financial_instrument_held_by_enu"`,
);
await queryRunner.query(
`ALTER TYPE "alcs"."application_instrument_type" RENAME TO "application_decision_condition_financial_instrument_type_enum"`,
);
}
}
14 changes: 14 additions & 0 deletions ...cs/src/providers/typeorm/migrations/1741289414578-add_default_to_app_instrument_status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { MigrationInterface, QueryRunner } from "typeorm";

export class AddDefaultToAppInstrumentStatus1741289414578 implements MigrationInterface {
name = 'AddDefaultToAppInstrumentStatus1741289414578'

public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "alcs"."application_decision_condition_financial_instrument" ALTER COLUMN "status" SET DEFAULT 'Received'`);
}

public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`ALTER TABLE "alcs"."application_decision_condition_financial_instrument" ALTER COLUMN "status" DROP DEFAULT`);
}

}