Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment PR - 1510 #2127

Merged
merged 142 commits into from
Mar 6, 2025
Merged

Deployment PR - 1510 #2127

merged 142 commits into from
Mar 6, 2025

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

Abradat and others added 7 commits February 11, 2025 16:21
- Entity
- DTOs
- Database Migration
- Add instrument to application decision condition entity
- Add number validator for status date
- Add optional validator for explanation
- Application decision condition financial instrument service
- Add financial instrument APIs to decision condition controller
- Add financial instrument to decision condition DTO
- Add mappers
- Add new mock entities for condition type and financial instrument
2486: Add 'No Data' to date chips
ALCS-2546: Merge hotfix to dev
542-2534: Application Financial Instrument Backend
fbarreta and others added 2 commits February 19, 2025 09:55
Show modification and reconsideration pills on application and NOI condition cards when the file has modification or reconsideration request instead of the decision
dylanrogowsky-oxd and others added 2 commits March 4, 2025 20:27
Potential fix for code scanning alert no. 3: Expression injection in Actions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Backport: ALCS-2227: Configure dependabot
Backport: ALCS-2579: QA #1: Don't overwrite options object
trslater added 5 commits March 6, 2025 10:51
- Make user email column nullable
- Make all user email DTO fields optional
- Disable subtask email filtering when email absent
- Check for email before sending new user request email
ALCS-2522: Make user email optional
trslater and others added 5 commits March 6, 2025 10:38
- The changes fixes enum data type names being truncated due to 63-byte name limit by PostgreSQL database.
- Apply to applications and NOIs
ALCS-2522: Send user request email even if no email provided
Rename Financial Instrument Data Type Enums and Add Default to Status Column
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
24.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

trslater
trslater previously approved these changes Mar 6, 2025
Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions github-actions bot dismissed trslater’s stale review March 6, 2025 23:19

The merge-base changed after approval.

@trslater trslater merged commit 021ae96 into main Mar 6, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants