ALCS-2081 Added condition cards on homepage #2095
Conversation
There was a problem hiding this comment.
Overall, I think it would be better that we create and maintain DTOs for specific cases. By keeping them general, we would grow them bigger over time according to our use cases, and it would introduce issues such as performance, dependency, etc.
My suggestion would be to create a customized DTO for this specific use case so we don't touch other DTOs and don't add more fields to them like Application Decision DTO.
"ApplicationDecisionConditionCardBoardDto" can be an example that is customized for a specific use case. Most of the fields such as "decisionOrder", "decisionUuid", "decisionIsFlagged", "isReconsideration", and "isModification" are required for this specific use case, so they're fetched from different services and mapped to this DTO.
...ion-condition/application-decision-condition-card/application-decision-condition-card.dto.ts
Show resolved
Hide resolved
...cs/application-decision/application-decision-condition/application-decision-condition.dto.ts
Outdated
Show resolved
Hide resolved
...pplication-decision/application-decision-v2/application-decision/application-decision.dto.ts
Outdated
Show resolved
Hide resolved
alcs-frontend/src/app/features/home/assigned/assigned.component.ts
Outdated
Show resolved
Hide resolved
Condition Cards on homepage