Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ALCS UI/UX Bugs #1740

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Fix ALCS UI/UX Bugs #1740

merged 3 commits into from
Jun 4, 2024

Conversation

Abradat
Copy link
Collaborator

@Abradat Abradat commented Jun 4, 2024

Following UI/UX bugs have been fixed:

  • ng-select dropdown border, placeholder, and arrow colour fixed to ALCS primary instead of blue
  • Fixed cursor remaining in the pointer state after clicking on proposal summary's inline text area

Abradat added 3 commits June 3, 2024 11:51
@Abradat
Fix cursor remaining in pointer state after clicking on proposal summ…
5f193c0 
…ary text area.

Cursor changes to text state after clicking on proposal summary text area and changes back to cursor on submission or cancelation.
@Abradat
fix ng-select border, dropdown, arrow, and placeholder colour to ALCS…
a295ceb 
… primary
@Abradat
Fix styling
5935958
@Abradat Abradat changed the title Fix UI/UX Bugs Fix ALCS UI/UX Bugs Jun 4, 2024
trslater
trslater approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

!important is not my favourite, but it does seem like it is necessary when battling Angular Material.

@Abradat Abradat merged commit f195562 into develop Jun 4, 2024
3 checks passed
@Abradat Abradat deleted the feature/ALCS-733 branch June 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trslater trslater trslater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abradat @trslater