Update Day Calculations to not count pauses AFTER decision_date #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaselhan
commented
May 27, 2024
| "alcs"."notice_of_intent" | ||
| LEFT JOIN "alcs"."notice_of_intent_meeting" ON | ||
| "notice_of_intent"."uuid" = "notice_of_intent_meeting"."notice_of_intent_uuid" | ||
| AND start_date <= COALESCE("decision_date", NOW()) |
There was a problem hiding this comment.
This line was changed, adding AND start_date <= COALESCE("decision_date", NOW())
dhaselhan
commented
May 27, 2024
| COALESCE(t1.end_date, NOW()) >= t2.start_date | ||
| AND COALESCE(t1.end_date, NOW()) < COALESCE(t2.end_date, NOW()) --- use coalesce since end_date may be null | ||
| AND t1.application_uuid = t2.application_uuid) | ||
| LEFT JOIN alcs.application ON application.uuid = s1.application_uuid |
There was a problem hiding this comment.
This join was added
dhaselhan
commented
May 27, 2024
| AND s1.start_date <= COALESCE(s2.end_date, NOW()) | ||
| AND s1.application_uuid = s2.application_uuid) | ||
| AND s1.application_uuid = ANY (p_ids) | ||
| AND s1.start_date <= COALESCE(application.decision_date, NOW()) |
There was a problem hiding this comment.
And this AND here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.