Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning Reviews V2 Pt.1 #1481

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Planning Reviews V2 Pt.1 #1481

merged 2 commits into from
Mar 7, 2024

Conversation

dhaselhan
Copy link
Collaborator

  • Delete old V1 reviews
  • Add Referrals as sub entities
  • Update creation flow and dialog for V2
  • Update unarchive card
  • Remove Non-application search as it will become Planning Review Search

@dhaselhan dhaselhan force-pushed the feature/ALCS-1423 branch from edcb70b to 3963eea Compare March 6, 2024 18:36
* Delete old V1 reviews
* Add Referrals as sub entities
* Update creation flow and dialog for V2
* Update unarchive card
* Remove Non-application search as it will become Planning Review Search
@dhaselhan dhaselhan force-pushed the feature/ALCS-1423 branch from 3963eea to 138bd54 Compare March 6, 2024 18:55
@@ -5,6 +5,7 @@ export enum BOARD_CODES {
CEO = 'ceo',
SOIL = 'soil',
EXECUTIVE_COMMITTEE = 'exec',
REGIONAL_PLANNING = 'rppp',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rppp 😄

Copy link
Collaborator

@mhuseinov mhuseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Just to clarify, will this feature be deployed to production in current state or is it going to be merged after the test/prod deployment?

@dhaselhan
Copy link
Collaborator Author

👍 Just to clarify, will this feature be deployed to production in current state or is it going to be merged after the test/prod deployment?

Yep! Gonna hold off since this is definitely not ready to go out the door.

@dhaselhan dhaselhan force-pushed the feature/ALCS-1423 branch from 9909ee4 to f72ab31 Compare March 6, 2024 19:48
Copy link
Collaborator

@trslater trslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

This one was a whopper!

@dhaselhan dhaselhan merged commit 0b52aa1 into develop Mar 7, 2024
3 checks passed
@dhaselhan dhaselhan deleted the feature/ALCS-1423 branch March 7, 2024 19:04
@dhaselhan dhaselhan restored the feature/ALCS-1423 branch March 7, 2024 19:04
@dhaselhan dhaselhan deleted the feature/ALCS-1423 branch March 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants