-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planning Reviews V2 Pt.1 #1481
Planning Reviews V2 Pt.1 #1481
Conversation
dhaselhan
commented
Mar 6, 2024
- Delete old V1 reviews
- Add Referrals as sub entities
- Update creation flow and dialog for V2
- Update unarchive card
- Remove Non-application search as it will become Planning Review Search
edcb70b
to
3963eea
Compare
* Delete old V1 reviews * Add Referrals as sub entities * Update creation flow and dialog for V2 * Update unarchive card * Remove Non-application search as it will become Planning Review Search
3963eea
to
138bd54
Compare
@@ -5,6 +5,7 @@ export enum BOARD_CODES { | |||
CEO = 'ceo', | |||
SOIL = 'soil', | |||
EXECUTIVE_COMMITTEE = 'exec', | |||
REGIONAL_PLANNING = 'rppp', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rppp 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just to clarify, will this feature be deployed to production in current state or is it going to be merged after the test/prod deployment?
services/apps/alcs/src/alcs/planning-review/planning-referral/planning-referral.entity.ts
Outdated
Show resolved
Hide resolved
Yep! Gonna hold off since this is definitely not ready to go out the door. |
9909ee4
to
f72ab31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
This one was a whopper!