Merge pull request #1785 from bcgov/bugfix/ALCS-2065-3

Prevent User From Submitting an Invalid Inline Number Form by Enter Key
bcgov · Jul 8, 2024 · ea3eb25 · ea3eb25
2 parents f1501d2 + 4b7de21
commit ea3eb25
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/alcs-frontend/src/app/shared/inline-editors/inline-number/inline-number.component.html b/alcs-frontend/src/app/shared/inline-editors/inline-number/inline-number.component.html
@@ -25,7 +25,7 @@
           name="value"
           [placeholder]="placeholder"
           #editInput
-          (keydown.enter)="confirmEdit()"
+          (keydown.enter)="!valueControl.invalid ? confirmEdit(): preventKeydown($event)"
           (keydown.escape)="cancelEdit()"
           [formControl]="valueControl"
         />

diff --git a/alcs-frontend/src/app/shared/inline-editors/inline-number/inline-number.component.ts b/alcs-frontend/src/app/shared/inline-editors/inline-number/inline-number.component.ts
@@ -52,4 +52,9 @@ export class InlineNumberComponent implements AfterContentChecked {
     this.isEditing = false;
     this.valueControl.setValue(this.value);
   }
+
+  preventKeydown(event: Event) {
+    const keyboardEvent = event as KeyboardEvent;
+    keyboardEvent.preventDefault();
+  }
 }