Code Review Feedback

bcgov · Oct 31, 2023 · 62ad1c9 · 62ad1c9
1 parent 2a66fad
commit 62ad1c9
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/...ication/decision/decision-v2/decision-component/expiry-date/expiry-date.component.spec.ts b/...ication/decision/decision-v2/decision-component/expiry-date/expiry-date.component.spec.ts
@@ -4,7 +4,7 @@ import { ApplicationDecisionComponentDto } from '../../../../../../services/appl
 
 import { ExpiryDateComponent } from './expiry-date.component';
 
-describe('TurpComponent', () => {
+describe('ExpiryDateComponent', () => {
   let component: ExpiryDateComponent;
   let fixture: ComponentFixture<ExpiryDateComponent>;
 

diff --git a/...-v2/decision-input/decision-components/decision-component/decision-component.component.ts b/...-v2/decision-input/decision-components/decision-component/decision-component.component.ts
@@ -11,7 +11,7 @@ import {
   ProposedDecisionLotDto,
   RosoDecisionComponentDto,
   SubdDecisionComponentDto,
-  TurpDecisionComponentDto,
+  ExpiryDateDecisionComponentDto,
 } from '../../../../../../../services/application/decision/application-decision-v2/application-decision-v2.dto';
 import { ToastService } from '../../../../../../../services/toast/toast.service';
 import { AG_CAP_OPTIONS, AG_CAP_SOURCE_OPTIONS } from '../../../../../../../shared/dto/ag-cap.types.dto';
@@ -41,7 +41,7 @@ export class DecisionComponentComponent implements OnInit {
   nfuSubType = new FormControl<string | null>(null, [Validators.required]);
   endDate = new FormControl<Date | null>(null, [Validators.required]);
 
-  // expiry-date & cove
+  // turp & cove
   expiryDate = new FormControl<Date | null>(null);
 
   // pofo, pfrs
@@ -285,7 +285,7 @@ export class DecisionComponentComponent implements OnInit {
     };
   }
 
-  private getExpiryDateDataChange(): TurpDecisionComponentDto {
+  private getExpiryDateDataChange(): ExpiryDateDecisionComponentDto {
     return {
       expiryDate: this.expiryDate.value ? formatDateForApi(this.expiryDate.value) : null,
     };

diff --git a/...decision-components/decision-component/expiry-date-input/expiry-date-input.component.html b/...decision-components/decision-component/expiry-date-input/expiry-date-input.component.html
@@ -1,4 +1,4 @@
-<form [formGroup]="form" class="turp-component-form">
+<form [formGroup]="form">
   <div class="grid-2">
     <mat-form-field appearance="outline">
       <mat-label>ALR Area Impacted (ha)</mat-label>

diff --git a/...ision-components/decision-component/expiry-date-input/expiry-date-input.component.spec.ts b/...ision-components/decision-component/expiry-date-input/expiry-date-input.component.spec.ts
@@ -3,7 +3,7 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { ExpiryDateInputComponent } from './expiry-date-input.component';
 
-describe('TurpInputComponent', () => {
+describe('ExpiryDateInputComponent', () => {
   let component: ExpiryDateInputComponent;
   let fixture: ComponentFixture<ExpiryDateInputComponent>;
 

diff --git a/...put/decision-components/decision-component/incl-excl-input/incl-excl-input.component.html b/...put/decision-components/decision-component/incl-excl-input/incl-excl-input.component.html
@@ -1,4 +1,4 @@
-<form [formGroup]="form" class="turp-component-form">
+<form [formGroup]="form">
   <div class="grid">
     <mat-form-field appearance="outline">
       <mat-label>ALR Area Impacted (ha)</mat-label>

diff --git a/.../app/services/application/decision/application-decision-v2/application-decision-v2.dto.ts b/.../app/services/application/decision/application-decision-v2/application-decision-v2.dto.ts
@@ -129,7 +129,7 @@ export interface NfuDecisionComponentDto {
   endDate?: number | null;
 }
 
-export interface TurpDecisionComponentDto {
+export interface ExpiryDateDecisionComponentDto {
   expiryDate?: number | null;
 }
 
@@ -169,7 +169,7 @@ export interface InclExclDecisionComponentDto {
 
 export interface ApplicationDecisionComponentDto
   extends NfuDecisionComponentDto,
-    TurpDecisionComponentDto,
+    ExpiryDateDecisionComponentDto,
     PofoDecisionComponentDto,
     RosoDecisionComponentDto,
     NaruDecisionComponentDto,