Merge pull request #2050 from bcgov/hotfix/ALCS-2451-check-zero-on-ad…

…min-fee-dev-merge ALCS-2451 Allow to remove check box if the value is zero
bcgov · Jan 7, 2025 · 1d91eec · 1d91eec
2 parents 3a53525 + eedaa74
commit 1d91eec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...dition-types/decision-condition-types-dialog/decision-condition-types-dialog.component.ts b/...dition-types/decision-condition-types-dialog/decision-condition-types-dialog.component.ts
@@ -202,12 +202,12 @@ export class DecisionConditionTypesDialogComponent {
   hasAdminFee(
     conditions: Partial<ApplicationDecisionConditionDto>[] | Partial<NoticeOfIntentDecisionConditionDto>[],
   ): boolean {
-    return conditions.map((c) => c.administrativeFee).filter((f) => f !== null).length > 0;
+    return conditions.map((c) => c.administrativeFee).filter((f) => f !== null && f !== undefined && f > 0).length > 0;
   }
 
   hasSecurityAmount(
     conditions: Partial<ApplicationDecisionConditionDto>[] | Partial<NoticeOfIntentDecisionConditionDto>[],
   ): boolean {
-    return conditions.map((c) => c.securityAmount).filter((f) => f !== null).length > 0;
+    return conditions.map((c) => c.securityAmount).filter((f) => f !== null && f !== undefined && f > 0).length > 0;
   }
 }
diff --git a/...end/src/app/features/admin/decision-condition-types/decision-condition-types.component.ts b/...end/src/app/features/admin/decision-condition-types/decision-condition-types.component.ts
@@ -80,7 +80,7 @@ export class DecisionConditionTypesComponent implements OnInit {
         conditionService: this.conditionService,
         content: dto,
         existingCodes: this.decisionConditionTypeCodeDtos,
-        existingDescriptions: this.decisionConditionTypeDescriptionDtos,
+        existingDescriptions: this.decisionConditionTypeDescriptionDtos.filter((d) => d !== dto.description),
       },
     });
     dialog.beforeClosed().subscribe(async (result) => {