PSP-9095 User is not able to delete the requisition

source/backend/dal/Repositories/CompensationRequisitionRepository.cs

@@ -104,6 +104,7 @@ public bool TryDelete(long compensationId)
                 .Include(p => p.PimsPropAcqFlCompReqs)
                 .Include(l => l.PimsPropLeaseCompReqs)
                 .Include(s => s.PimsLeaseStakeholderCompReqs)
+                .Include(ap => ap.PimsCompReqPayees)
                 .AsNoTracking()
                 .FirstOrDefault(c => c.CompensationRequisitionId == compensationId);
 
@@ -129,6 +130,11 @@ public bool TryDelete(long compensationId)
                     Context.PimsLeaseStakeholderCompReqs.Remove(new PimsLeaseStakeholderCompReq() { LeaseStakeholderCompReqId = compReqLeaseStakeholder.LeaseStakeholderCompReqId });
                 }
 
+                foreach (var compReqAcqPayee in deletedEntity.PimsCompReqPayees)
+                {
+                    Context.PimsCompReqPayees.Remove(new() { CompReqPayeeId = compReqAcqPayee.CompReqPayeeId });
+                }
+
                 Context.CommitTransaction(); // TODO: required to enforce delete order. Can be removed when cascade deletes are implemented.
 
                 Context.PimsCompensationRequisitions.Remove(new PimsCompensationRequisition() { CompensationRequisitionId = deletedEntity.CompensationRequisitionId });

source/backend/tests/unit/api/Services/CompensationRequisitionServiceTest.cs

@@ -555,7 +555,7 @@ public void Update_Status_BackToDraft_NoPermission()
             });
 
             // Assert
-            act.Should().Throw<BusinessRuleViolationException>();
+            act.Should().Throw<BusinessRuleViolationException>().WithMessage("The file you are editing is not active or hold, so you cannot save changes. Refresh your browser to see file state.");
         }
 
         [Fact]
@@ -1048,6 +1048,62 @@ public void Delete_Success()
             compRepository.Verify(x => x.TryDelete(It.IsAny<long>()), Times.Once);
         }
 
+        [Fact]
+        public void Delete_InvalidStatus()
+        {
+            // Arrange
+            var service = this.CreateCompRequisitionServiceWithPermissions(Permissions.CompensationRequisitionDelete);
+            var compRepository = this._helper.GetService<Mock<ICompensationRequisitionRepository>>();
+            compRepository.Setup(x => x.TryDelete(It.IsAny<long>()));
+            compRepository.Setup(x => x.GetById(It.IsAny<long>())).Returns(new PimsCompensationRequisition { Internal_Id = 1, AcquisitionFileId = 1 });
+
+            var acqFileRepository = this._helper.GetService<Mock<IAcquisitionFileRepository>>();
+            acqFileRepository.Setup(x => x.GetById(It.IsAny<long>())).Returns(
+              new PimsAcquisitionFile()
+              {
+                  AcquisitionFileId = 1,
+                  AcquisitionFileStatusTypeCode = AcquisitionStatusTypes.ACTIVE.ToString()
+              });
+
+            var solver = this._helper.GetService<Mock<IAcquisitionStatusSolver>>();
+            solver.Setup(x => x.CanEditOrDeleteCompensation(It.IsAny<AcquisitionStatusTypes?>(), It.IsAny<bool?>())).Returns(false);
+
+            // Act
+            Action act = () => service.DeleteCompensation(1);
+
+            // Assert
+            act.Should().Throw<BusinessRuleViolationException>().WithMessage("The file you are editing is not active or hold, so you cannot save changes. Refresh your browser to see file state.");
+            compRepository.Verify(x => x.TryDelete(It.IsAny<long>()), Times.Never);
+        }
+
+        [Fact]
+        public void Delete_InvalidStatus_AuthorizedAdmin()
+        {
+            // Arrange
+            var service = this.CreateCompRequisitionServiceWithPermissions(Permissions.CompensationRequisitionDelete, Permissions.SystemAdmin);
+            var compRepository = this._helper.GetService<Mock<ICompensationRequisitionRepository>>();
+            compRepository.Setup(x => x.TryDelete(It.IsAny<long>()));
+            compRepository.Setup(x => x.GetById(It.IsAny<long>())).Returns(new PimsCompensationRequisition { Internal_Id = 1, AcquisitionFileId = 1 });
+
+            var acqFileRepository = this._helper.GetService<Mock<IAcquisitionFileRepository>>();
+            acqFileRepository.Setup(x => x.GetById(It.IsAny<long>())).Returns(
+              new PimsAcquisitionFile()
+              {
+                  AcquisitionFileId = 1,
+                  AcquisitionFileStatusTypeCode = AcquisitionStatusTypes.ACTIVE.ToString()
+              });
+
+            var solver = this._helper.GetService<Mock<IAcquisitionStatusSolver>>();
+            solver.Setup(x => x.CanEditOrDeleteCompensation(It.IsAny<AcquisitionStatusTypes?>(), It.IsAny<bool?>())).Returns(false);
+
+            // Act
+            service.DeleteCompensation(1);
+
+            // Assert
+            compRepository.Verify(x => x.TryDelete(It.IsAny<long>()), Times.Once);
+        }
+
+
         private CompensationRequisitionService CreateCompRequisitionServiceWithPermissions(params Permissions[] permissions)
         {
             var user = PrincipalHelper.CreateForPermission(permissions);

source/backend/tests/unit/dal/Repositories/CompensationRequisitionRepositoryTest.cs

@@ -207,6 +207,120 @@ public void DeleteCompensationRequisition_NotFound()
             result.Should().BeFalse();
         }
 
+        [Fact]
+        public void DeleteCompensationRequisition_CascadeDelete_SubEntities_ACQUISITION()
+        {
+            // Arrange
+            var compReq = EntityHelper.CreateCompensationRequisition(id: 1);
+            compReq.AcquisitionFileId = 1;
+            compReq.PimsCompReqFinancials.Add(
+                new()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                    FinancialActivityCodeId = 100,
+                    FinancialActivityCode = new()
+                    {
+                        Id = 100,
+                        Code = "TEST",
+                        Description = "Lorem Ipsum"
+                    }
+                });
+            compReq.PimsPropAcqFlCompReqs.Add(
+                new()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                    PropertyAcquisitionFileId = 1,
+                    PropertyAcquisitionFile = new()
+                    {
+                        AcquisitionFileId = 1,
+                        PropertyId = 12345,
+                        Property = EntityHelper.CreateProperty(12345),
+                    }
+                });
+
+            compReq.PimsCompReqPayees.Add(
+                new()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                    AcquisitionOwnerId = 1
+                });
+
+            var repository = CreateWithPermissions(Permissions.CompensationRequisitionDelete);
+            var context = _helper.AddAndSaveChanges(compReq);
+
+            // Act
+            context.ChangeTracker.Clear();
+            var result = repository.TryDelete(compReq.Internal_Id);
+            context.CommitTransaction();
+
+            // Assert
+            result.Should().BeTrue();
+            context.PimsCompensationRequisitions.Should().BeEmpty();
+            context.PimsCompReqFinancials.Should().BeEmpty();
+            context.PimsPropAcqFlCompReqs.Should().BeEmpty();
+            context.PimsCompReqPayees.Should().BeEmpty();
+        }
+
+        [Fact]
+        public void DeleteCompensationRequisition_CascadeDelete_SubEntities_LEASE()
+        {
+            // Arrange
+            var compReq = EntityHelper.CreateCompensationRequisition(id: 1);
+            compReq.LeaseId = 1;
+            compReq.PimsCompReqFinancials.Add(
+                new()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                    FinancialActivityCodeId = 100,
+                    FinancialActivityCode = new()
+                    {
+                        Id = 100,
+                        Code = "TEST",
+                        Description = "Lorem Ipsum"
+                    }
+                });
+            compReq.PimsPropLeaseCompReqs.Add(
+                new()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                    PropertyLeaseId = 1,
+                    PropertyLease = new()
+                    {
+                        LeaseId = 1,
+                        PropertyId = 12345,
+                        Property = EntityHelper.CreateProperty(12345),
+                    }
+                });
+
+            compReq.PimsLeaseStakeholderCompReqs.Add(
+                new()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                    LeaseStakeholderId = 1
+                });
+
+            var repository = CreateWithPermissions(Permissions.CompensationRequisitionDelete);
+            var context = _helper.AddAndSaveChanges(compReq);
+
+            // Act
+            context.ChangeTracker.Clear();
+            var result = repository.TryDelete(compReq.Internal_Id);
+            context.CommitTransaction();
+
+            // Assert
+            result.Should().BeTrue();
+            context.PimsCompensationRequisitions.Should().BeEmpty();
+            context.PimsCompReqFinancials.Should().BeEmpty();
+            context.PimsPropLeaseCompReqs.Should().BeEmpty();
+            context.PimsLeaseStakeholderCompReqs.Should().BeEmpty();
+        }
+
         [Fact]
         public void GetAcquisitionCompReqPropertiesById_Success()
         {
@@ -268,5 +382,76 @@ public void GetLeaseCompReqPropertiesById_Success()
             result.First().Property.Pid.Should().Be(12345);
             result.First().Property.Location.SRID.Should().Be(SpatialReference.BCALBERS); // repository should return property location in BCALBERS projection
         }
+
+        [Fact]
+        public void GetCompensationRequisitionFinancials_Success()
+        {
+            // Arrange
+            PimsCompReqFinancial[] financials =
+            {
+                new ()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                    FinancialActivityCodeId = 100,
+                },
+                new ()
+                {
+                    Internal_Id = 2,
+                    CompensationRequisitionId = 1,
+                    FinancialActivityCodeId = 100,
+                },
+            };
+
+            var repository = CreateWithPermissions(Permissions.CompensationRequisitionView);
+            _helper.AddAndSaveChanges<PimsCompReqFinancial>(financials);
+            _helper.AddAndSaveChanges<PimsFinancialActivityCode>(
+                new PimsFinancialActivityCode()
+                {
+                    Id = 100,
+                    Code = "TEST",
+                    Description = "lorem ipsum"
+                });
+
+            // Act
+            var result = repository.GetCompensationRequisitionFinancials(1);
+
+            // Assert
+            result.Should().NotBeNull();
+            result.Should().BeAssignableTo<IEnumerable<PimsCompReqFinancial>>();
+            result.Should().HaveCount(2);
+            result.First().CompensationRequisitionId.Should().Be(1);
+        }
+
+        [Fact]
+        public void GetCompensationRequisitionPayees_Success()
+        {
+            // Arrange
+            PimsCompReqPayee[] payees =
+            {
+                new ()
+                {
+                    Internal_Id = 1,
+                    CompensationRequisitionId = 1,
+                },
+                new ()
+                {
+                    Internal_Id = 2,
+                    CompensationRequisitionId = 1,
+                },
+            };
+
+            var repository = CreateWithPermissions(Permissions.CompensationRequisitionView);
+            _helper.AddAndSaveChanges<PimsCompReqPayee>(payees);
+
+            // Act
+            var result = repository.GetCompensationRequisitionPayees(1);
+
+            // Assert
+            result.Should().NotBeNull();
+            result.Should().BeAssignableTo<IEnumerable<PimsCompReqPayee>>();
+            result.Should().HaveCount(2);
+            result.First().CompensationRequisitionId.Should().Be(1);
+        }
     }
 }