Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psp-9882 header corrections. #4627

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Psp-9882 header corrections. #4627

merged 4 commits into from
Feb 6, 2025

Conversation

devinleighsmith
Copy link
Collaborator

Note that this is a "best-effort" attempt based on poor story definition.

@devinleighsmith devinleighsmith self-assigned this Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

asanchezr
asanchezr reviewed Feb 4, 2025
View reviewed changes
source/backend/api/Repositories/Cdogs/CdogsAuthRepository.cs Outdated
Comment on lines 37 to 39
IOptions<JsonSerializerOptions> jsonOptions,
ResiliencePipelineProvider<string> pollyPipelineProvider)
: base(logger, httpClientFactory, configuration, jsonOptions, pollyPipelineProvider)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look unrelated to this UI/UX story. Please rebase your branch so only relevant changes are shown

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

@devinleighsmith devinleighsmith force-pushed the psp-9882 branch 2 times, most recently from 5eeddaa to b54e844 Compare February 5, 2025 23:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4627

@asanchezr asanchezr merged commit a20df72 into bcgov:dev Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanchezr asanchezr asanchezr approved these changes

Assignees

@devinleighsmith devinleighsmith

Labels
ui/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinleighsmith @asanchezr