Psp 9893 mayan document queue corrections. #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinleighsmith
force-pushed
the
psp-9893
branch
from
349a71d to
c1e88c3
Compare
devinleighsmith
commented
Jan 23, 2025
| databaseDocumentQueue.DocProcessRetries += 1; | ||
| databaseDocumentQueue.DocProcessEndDt = null; | ||
| } | ||
|
|
||
| bool isValid = ValidateQueuedDocument(databaseDocumentQueue, documentQueue); |
There was a problem hiding this comment.
the above logic needs to run after this check - to avoid the processDocRetries from being changed.
devinleighsmith
commented
Jan 23, 2025
| if (databaseDocumentQueue.DocumentQueueStatusTypeCode == DocumentQueueStatusTypes.PIMS_ERROR.ToString() || databaseDocumentQueue.DocumentQueueStatusTypeCode == DocumentQueueStatusTypes.MAYAN_ERROR.ToString()) | ||
| { | ||
| this.Logger.LogDebug("Document Queue {documentQueueId}, previously errored, retrying", documentQueue.DocumentQueueId); | ||
| databaseDocumentQueue.DocProcessRetries = ++databaseDocumentQueue.DocProcessRetries ?? 1; |
There was a problem hiding this comment.
using += does not work on a null value.
devinleighsmith
commented
Jan 23, 2025
| @@ -243,12 +243,6 @@ public async Task<PimsDocumentQueue> Upload(PimsDocumentQueue documentQueue) | |||
| UpdateDocumentQueueStatus(databaseDocumentQueue, DocumentQueueStatusTypes.PIMS_ERROR); | |||
| return databaseDocumentQueue; | |||
| } | |||
| else if (relatedDocument?.MayanId != null && relatedDocument?.MayanId > 0) | |||
There was a problem hiding this comment.
This is incorrect, in addition to having a mayanId, we need to wait for the filedetail to be available.
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4611 |
2 similar comments
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4611 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4611 |
asanchezr
approved these changes
Jan 23, 2025
|
@devinleighsmith - this doesn't look right... |
devinleighsmith
force-pushed
the
psp-9893
branch
from
2689904 to
24f274f
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.