Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create account CRUD #21

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

jadmsaadaot
Copy link
Collaborator

@jadmsaadaot jadmsaadaot commented Jul 30, 2024

https://apps.nrs.gov.bc.ca/int/jira/browse/EPICSYSTEM-208

  • Add create account resource
  • Add request schemas
  • Add services
  • Add model methods

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 55.22388% with 60 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (44b578e) to head (cb0f474).

Files Patch % Lines
...mit-api/src/submit_api/services/account_service.py 39.53% 26 Missing ⚠️
submit-api/src/submit_api/models/db.py 27.27% 8 Missing ⚠️
submit-api/src/submit_api/models/account.py 41.66% 7 Missing ⚠️
submit-api/src/submit_api/models/account_role.py 25.00% 6 Missing ⚠️
submit-api/src/submit_api/models/account_user.py 25.00% 6 Missing ⚠️
submit-api/src/submit_api/resources/account.py 78.57% 6 Missing ⚠️
submit-api/src/submit_api/models/role.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #21       +/-   ##
============================================
+ Coverage    30.70%   74.88%   +44.18%     
============================================
  Files           23       27        +4     
  Lines          241      677      +436     
  Branches        46        0       -46     
============================================
+ Hits            74      507      +433     
- Misses         154      170       +16     
+ Partials        13        0       -13     
Flag Coverage Δ
submit-api 74.88% <55.22%> (?)
submit-web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jadmsaadaot jadmsaadaot merged commit c557b16 into bcgov:develop Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants