Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to place fallback for v2 calls. #428

Open
wants to merge 11 commits into
base: grad-release
Choose a base branch
from
Open

Changes to place fallback for v2 calls. #428

wants to merge 11 commits into from

Conversation

sumathi-thirumani
Copy link

@sumathi-thirumani sumathi-thirumani commented Feb 25, 2025 •
edited
Loading

Change Details:

  1. Fallback method to invoke institute api for redis functions
  2. Async redis refresh for rest calls
  3. Optimize schooldetails loadingg with pagination
  4. Optimized service method to identify districtsbyscoolcaregory.

cditcher
cditcher requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@cditcher cditcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, big change in the time it takes to cold-load the cache! Nice. Please see comments.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
77.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cditcher cditcher cditcher requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumathi-thirumani @cditcher