Added basic support for notifications #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs1m0n
reviewed
Feb 26, 2024
| 'title' => $translation->post_title, | ||
| 'language' => $language_code, | ||
| 'excerpt' => $excerpt, | ||
| 'url' => get_permalink( $translation->ID) ?? ($site_url . '/?p=' . $translation->ID . '&lang=' . $language_code), |
There was a problem hiding this comment.
Is it not better to link to the slug instead of the ID?
| } | ||
|
|
||
|
|
||
| function get_read_more_text($lang) { |
There was a problem hiding this comment.
You could instead use translation in WordPress for that: https://codex.wordpress.org/I18n_for_WordPress_Developers#Strings_for_Translation
| $request_url = "https://ca-notifications-api-prod.salmonmoss-1fccea79.westeurope.azurecontainerapps.io" . "/notifications/notification?createSubscribers=false&pushNotifications=true"; | ||
| $request_body = array( | ||
| "workflowId" => $workflow, | ||
| "groupUid" => $group_uids[0], //First group only for now |
There was a problem hiding this comment.
This needs a better solution before we go live, indeed! Taking only the first group isn't a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.