-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block support for the WordPress Core Editor. #4
base: master
Are you sure you want to change the base?
Conversation
Still very much wip.
I fixed the spacing between the icon and the text for the placeholder block, and added several more blocks as well. |
Added in stub textinput pickers for the remaining data types -- topics, replies, topic tags, and views. These could all be improved. I'd love to tweak them to pull data in via the Backbone WP API Client that ships in the core, but that's very much not my area of expertise especially working with custom post types and taxonomies and such. If possible, it would also be worth retooling the Forum picker to run off that, tbh. cc: @adamsilverstein maybe if you can give a hot take or any input here? (I think I'd heard that the backbone client is more your back yard) |
Hey @georgestephanis thanks for the ping. Given this is being built for the block editor, I think you have all the API's you need to get the data you want without using the Backbone client. I think we could build a data store that would fetch the data from the API. For the select itself, a native element works well when you have a small number of items (see WordPress/gutenberg#26077), for longer lists, I suggest using the (new) accessible autocomplete/search selector |
@georgestephanis I took a pass at adding the selector + data for the Forum picker in georgestephanis#1. The styling could use some work, some improvements are being worked on upstream - see https://github.com/WordPress/gutenberg/search?q=ComboboxControl+is%3Aissue&state=open&type=Issues & I started at the most complicated one (because it is hierarchical). I'll work on something simpler next! |
Add client side data, searchable ComboBox selector for ForumPicker.
Note to self: add script dependencies for |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Branch restored. PR re-opened. This was accidental. |
Trac Ticket: https://bbpress.trac.wordpress.org/ticket/3403