Skip to content

Commit

Permalink
Merge pull request #42 from bboyle/jquery
Browse files Browse the repository at this point in the history
verify plugin works in jquery 2.1.0
  • Loading branch information
bboyle committed Mar 27, 2014
2 parents 23fc926 + 25d4c9f commit 48df341
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 13 deletions.
15 changes: 13 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ module.exports = function( grunt ) {
unit: [ 'test/**/*.html' ],

// test other jquery versions
"jQuery 1.4.4": {
jquery: {
options: {
timeout: 12000,
urls: [
Expand All @@ -65,7 +65,18 @@ module.exports = function( grunt ) {
'http://localhost:8000/test/questions.html?jquery=1.4.4',
'http://localhost:8000/test/submit-suppression.html?jquery=1.4.4',
'http://localhost:8000/test/submit.html?jquery=1.4.4',
'http://localhost:8000/test/validationMessage.html?jquery=1.4.4'
'http://localhost:8000/test/validationMessage.html?jquery=1.4.4',
// 2.1.0
'http://localhost:8000/test/alert.html?jquery=2.1.0',
'http://localhost:8000/test/groups.html?jquery=2.1.0',
'http://localhost:8000/test/hints.html?jquery=2.1.0',
'http://localhost:8000/test/invalid.html?jquery=2.1.0',
'http://localhost:8000/test/labels.html?jquery=2.1.0',
'http://localhost:8000/test/markup.html?jquery=2.1.0',
'http://localhost:8000/test/questions.html?jquery=2.1.0',
'http://localhost:8000/test/submit-suppression.html?jquery=2.1.0',
'http://localhost:8000/test/submit.html?jquery=2.1.0',
'http://localhost:8000/test/validationMessage.html?jquery=2.1.0'
]
}
}
Expand Down
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
This is a form validation package I have developed to deliver the UX I want in web forms
that use the HTML5 constraint validation API.

This plugin *does not work* with jQuery 1.9+ due to the removal of [`.live()`](http://api.jquery.com/live/)

You're welcome to reuse, fork, modify etc. and chances are you will need to
(unless you like my markup and don't need any language other than English).

Expand Down Expand Up @@ -38,5 +36,3 @@ You may want to check out @jzaefferer's [jquery-validation](https://github.com/j
* separate submit suppression into a separate repo?
* html5 validation for test pages
* acceptance tests in multiple browsers
* test against different versions of jquery
* support jQuery 1.9+ (and continue backwards compatibility for jQuery 1.4.4+)
8 changes: 2 additions & 6 deletions dist/form-validation.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/submit-suppression.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


// bind submit counter
$( 'form' ).live( 'submit', function() {
$( document ).delegate( 'form', 'submit', function() {
submitted++;
ok( submitted <= 3, 'submit event detected' );
});
Expand Down

0 comments on commit 48df341

Please sign in to comment.