Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected for JVM crash by using more robust LTS JRE base image #652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hillct
Copy link

@hillct hillct commented Feb 8, 2025

Corrected for JVM crash by using more robust LTS JRE base image, saving 200MB in final image size as a bonus.
This work was done in an attempt to address #651 which it does not do completely, but the enhancements to the Dockerfile are generally beneficial in that they increase build predictability by shifting to the LTS OpenJRE image.

This has not been tested across all supported platform as I don't have any arm7 hardware with which to test. It should be noted that arm7 continues to utilize the old Jammy image, so it should be fine anyway.

@hillct hillct changed the title Corrected for JVM crash by using more robust LTS JRE base image, sabi… Corrected for JVM crash by using more robust LTS JRE base image Feb 8, 2025
@bbernhard
Copy link
Owner

I really appreciate the effort you put into this! However, I am a bit worried that having two different base images will increase the maintenance burden significantly. I had something like this in the early stages of this project and it was a bit of a pain to maintain and resulted in some subtle bugs. :/

I asked the eclipse-temurin guys a while ago whether they can re-enable the armv7 builds and I think there were also some active discussions about that, but I am not sure if there was actually some progress there. Need to look up that issue in their issue tracker.

That being said, I would definitely be more comfortable, if there would just be one base image for all the supported architectures. But I'll think about it a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants