Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event and click tracking to bullet list link #9654

Merged
merged 66 commits into from
Jan 18, 2022

Conversation

nicola-d-bbc
Copy link
Contributor

@nicola-d-bbc nicola-d-bbc commented Nov 8, 2021

Resolves #9731

Overall change:
Adds click and view tracking to bulleted lists that have links using the index.

Code changes:

  • Created new data transformer to add index to a block group
  • Added functionality to check if list block includes a urlLink
  • Added click and view tracking to BulletedList if the block includes a urlLink
  • Added tests for new data transformer as well as tests for tracking on bulleted list

Test pages

Bullet list (no links)
http://localhost:7080/arabic/23298105

Bullet list (links, single block)
http://localhost:7080/amharic/news-53260525
http://localhost:7080/portuguese/brasil-59057279

Bullet list (links, multiple blocks)
http://localhost:7080/afaanoromoo/oduu-53268428
http://localhost:7080/pidgin/tori-23463103
http://localhost:7080/azeri/international-53242449
http://localhost:7080/igbo/afirika-23252735


  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project
  • (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@nicola-d-bbc nicola-d-bbc self-assigned this Nov 9, 2021
@pvaliani pvaliani marked this pull request as ready for review November 15, 2021 12:00
Copy link
Contributor

@ryanmccombe ryanmccombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@DarioR01 DarioR01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question, does this work need an a11y swarm?

@nicola-d-bbc
Copy link
Contributor Author

LGTM, just a question, does this work need an a11y swarm?

Not sure. Since this is just adding tracking and isn't changing how the data is displayed I wouldn't think so, but with this bug possibly being related to tracking it might need one.

@DarioR01
Copy link
Contributor

LGTM, just a question, does this work need an a11y swarm?

Not sure. Since this is just adding tracking and isn't changing how the data is displayed I wouldn't think so, but with this bug possibly being related to tracking it might need one.

I am not sure if it is worth to be honest. If it is worth, I would suggest doing it after the bug is resolved. At the same time this might causes delays :/. Or we might discover that the bug was isolated to a single component. Either way it might be better to ask in stand-up or to @greenc05 on Monday. Thanks

Copy link
Contributor

@MuhammadAHussain MuhammadAHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paruchurisilpa paruchurisilpa self-assigned this Jan 17, 2022
@paruchurisilpa
Copy link
Contributor

Checked using the following links:

Bullet list (no links)

Bullet list (links, single block)

Bullet list (links, multiple blocks)

@nicola-d-bbc nicola-d-bbc merged commit a6c13bd into latest Jan 18, 2022
@nicola-d-bbc nicola-d-bbc deleted the list-link-tracking branch January 18, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track lists with links (sequential names)
10 participants